-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): remove redundant ${{ ... }} in if statements in workflows #4517
Conversation
1740506
to
b6770b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are all the remaining ${{ }}
s are necessary?
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4517 +/- ##
=======================================
- Coverage 67.7% 67.7% -0.1%
=======================================
Files 161 161
Lines 18845 18845
=======================================
- Hits 12769 12761 -8
- Misses 5315 5326 +11
+ Partials 761 758 -3 ☔ View full report in Codecov by Sentry. |
I think so @randmonkey only in |
Pull request was converted to draft
@programmer04 Are we still working on this 🤔 ? |
I put it on hold @pmalek because I discovered a quick that I wanted to clarify github/docs#27497. Now knowing that I lean towards putting |
Since omitting doesn't work always (see official docs) I'm not longer advocating for adjusting it |
What this PR does / why we need it:
When you use expressions in an if conditional, you may omit the
${{ ... }}
expression syntax because GitHub Actions automatically evaluates theif
conditional as an expression. Read more. I found a corner case where such omit is not applicable, e.g.kubernetes-ingress-controller/.github/workflows/_e2e_tests.yaml
Line 81 in b6770b6
read more here.
Issue created in GH docs github/docs#27497